murong00 edited a comment on issue #6394: Expect an option to disable auto 
creation of subscriptions
URL: https://github.com/apache/pulsar/issues/6394#issuecomment-591981269
 
 
   @sijie @codelipenghui The above proposal may not work for `Reader` due to 
`ReaderBuilderImpl` (i.e. `PulsarClientImpl.doCreateReaderAsync` which calls 
`ReaderImpl`) does not support to pass `subscription`, its implementation is 
hard-coded currently. 
https://github.com/apache/pulsar/blob/760bd1abfa5374bde85e4d938937a0410dfb2674/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ReaderImpl.java#L37-L43
   In addition, the current pulsar admin rest endpoints only support to create 
a `Durable` subscription which can not apply to `Reader`(or `Consumer` with a 
`NonDurable` subscription) whose subscription is `NonDurable`. 
https://github.com/apache/pulsar/blob/75a321dfbe23cbd979fa225ef4a3d2fc4201994b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L741-L744
   Should we skip the `NonDurable` subscriptions when checking to see if a 
subscription exists? Or maybe we can create it when it is `NonDurable`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to