sijie commented on a change in pull request #6445: Fixed avro schema decode
error in functions
URL: https://github.com/apache/pulsar/pull/6445#discussion_r386054716
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
##########
@@ -88,14 +97,19 @@ public boolean supportSchemaVersioning() {
return new AvroSchema<>(parseSchemaInfo(schemaDefinition,
SchemaType.AVRO));
}
+ public static <T> AvroSchema<T> ofWithClass(SchemaDefinition<T>
schemaDefinition) {
Review comment:
Do we need a separate static method? Why can we just check if
schemaDefinition has POJO? If it has POJO, when we create a schema instance, we
should include the POJO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
