vzhikserg commented on a change in pull request #6435: Make tests more stable 
by using JSONAssert equals
URL: https://github.com/apache/pulsar/pull/6435#discussion_r386094434
 
 

 ##########
 File path: 
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/JSONSchemaTest.java
 ##########
 @@ -44,13 +46,16 @@
 @Slf4j
 public class JSONSchemaTest {
 
+    public static void assertJSONEqual(String s1, String s2) throws 
JSONException{
 
 Review comment:
   For me, it seems like overkill to create a separate method for one line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to