sijie commented on a change in pull request #6383: [Issue 6043] Support force
deleting subscription
URL: https://github.com/apache/pulsar/pull/6383#discussion_r389502183
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -801,10 +825,12 @@ PartitionedTopicInternalStats
getPartitionedInternalStats(String topic)
* topic name
* @param subName
* Subscription name
+ * @param force
+ * Delete topic forcefully
*
* @return a future that can be used to track when the subscription is
deleted
*/
- CompletableFuture<Void> deleteSubscriptionAsync(String topic, String
subName);
+ CompletableFuture<Void> deleteSubscriptionAsync(String topic, String
subName, boolean force);
Review comment:
This is an API breaking change. You can't directly change the method
signature. Please add an override method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
