cbornet commented on a change in pull request #6512: WIP: [protocol] Grpc 
protocol handler
URL: https://github.com/apache/pulsar/pull/6512#discussion_r396991601

 File path: pulsar-protocols/grpc/src/main/proto/PulsarApi.proto
 @@ -0,0 +1,888 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+syntax = "proto2";
 Review comment:
   Because I don't like proto3 :smile:  : lack of optionals/nullables and 
default values...
   Also the API is a derivation from the Pulsar binary protocol which is in 
   We could consider upgrading to proto3 later.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to