codelipenghui commented on a change in pull request #6615: Export
ManagedLedgerCache metric to prometheus
URL: https://github.com/apache/pulsar/pull/6615#discussion_r399740905
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java
##########
@@ -75,12 +81,54 @@ public static void generate(PulsarService pulsar, boolean
includeTopicMetrics, b
FunctionsStatsGenerator.generate(pulsar.getWorkerService(),
pulsar.getConfiguration().getClusterName(), stream);
+ generateBrokerBasicMetrics(pulsar, stream);
+
out.write(buf.array(), buf.arrayOffset(), buf.readableBytes());
} finally {
buf.release();
}
}
+ private static void generateBrokerBasicMetrics(PulsarService pulsar,
SimpleTextOutputStream stream) {
+ String clusterName = pulsar.getConfiguration().getClusterName();
+ // generate managedLedgerCache metrics
+ parseMetricsToPrometheusMetrics(new
ManagedLedgerCacheMetrics(pulsar).generate(),
+ clusterName, "managedLedgerCache", Collector.Type.GAUGE,
stream);
+
+ // generate managerLedger metrics
+ parseMetricsToPrometheusMetrics(new
ManagedLedgerMetrics(pulsar).generate(),
+ clusterName, "manageLedger", Collector.Type.GAUGE, stream);
+
+ // generate brokerService topic metrics
+
parseMetricsToPrometheusMetrics(pulsar.getBrokerService().getTopicMetrics(),
+ clusterName, "brokerService", Collector.Type.GAUGE, stream);
+
+ // generate load manager loadBalancing metrics
+
parseMetricsToPrometheusMetrics(pulsar.getLoadManager().get().getLoadBalancingMetrics(),
+ clusterName, "loadBalancing", Collector.Type.GAUGE, stream);
+ }
+
+ private static void parseMetricsToPrometheusMetrics(Collection<Metrics>
metrics, String cluster, String metricName,
+ Collector.Type
metricType, SimpleTextOutputStream stream) {
+ stream.write("# TYPE ").write(metricName).write('
').write(getTypeStr(metricType)).write('\n');
+ for (Metrics metrics1 : metrics) {
+ String labels = "{cluster=\"" + cluster + "\"";
+ for (Map.Entry<String, String> entry :
metrics1.getDimensions().entrySet()) {
+ if (entry.getKey().isEmpty() ||
"cluster".equals(entry.getKey())) {
+ continue;
+ }
+ labels += ", " + entry.getKey() + "=\"" + entry.getValue() +
"\"";
+ }
+ labels += "} ";
+
+ for (Map.Entry<String, Object> entry :
metrics1.getMetrics().entrySet()) {
+ stream.write(entry.getKey().replace(".", ":")).write(labels)
Review comment:
If we use metrics key in `ManagedLedgerMetrics` or
`ManagedLedgerCacheMetrics` to convert to OpenMetrics(Prometheus) data format
metrics directly, this may cause inconsistencies with the metrics format that
has been exposed in Prometheus. For example, we use "pulsar_" as the prefix of
all broker metrics. If we expose some broker level metrics with `brk_` prefix,
this can be confusing for users.
So, I think we need to be as consistent as possible with the current format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
