murong00 commented on a change in pull request #5985: [Issue 5935] Support 
multi pulsar clusters to use the same bk cluster
URL: https://github.com/apache/pulsar/pull/5985#discussion_r402709553
 
 

 ##########
 File path: 
pulsar-common/src/main/java/org/apache/pulsar/common/conf/InternalConfigurationData.java
 ##########
 @@ -28,19 +28,19 @@
 
     private String zookeeperServers;
     private String configurationStoreServers;
-    private String ledgersRootPath;
+    private String metadataServiceUri;
 
 Review comment:
   @jiazhai In fact, `metadataServiceUri` here is a uri to connect to a 
zookeeper cluster, which is used to find bookies. I would prefer to keep it 
since `ledgersRootPath` seems more like a path and is using together with 
zookeeper. As sijie's comment above, we are trying to use a metadata service 
uri, so how about `bkMetadataServiceUri`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to