gaoran10 commented on a change in pull request #6335: Refactored JCloud Tiered
Storage
URL: https://github.com/apache/pulsar/pull/6335#discussion_r407179956
##########
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreManagedLedgerOffloader.java
##########
@@ -589,26 +299,17 @@ BlobStore getReadBlobStore(Map<String, String>
offloadDriverMetadata) {
return promise;
}
- public interface VersionCheck {
- void check(String key, Blob blob) throws IOException;
- }
-
+
@Override
public OffloadPolicies getOffloadPolicies() {
- return offloadPolicies;
+ // TODO Auto-generated method stub
+ return null;
}
Review comment:
Currently, when the `LedgerOffloader` is generated by the `PulsarService`,
the `PulsarService` will check the namespace's `OffloadPolicies`, if the new
`OffloadPolicies` is same as the existing `OffloadPolicies`, the
`PulsarService` will reuse the existing `LedgerOffloader`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
