cbornet commented on a change in pull request #6720: Make ServerCnx independent
of Netty
URL: https://github.com/apache/pulsar/pull/6720#discussion_r407538209
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java
##########
@@ -65,7 +65,7 @@
public class Consumer {
private final Subscription subscription;
private final SubType subType;
- private final ServerCnx cnx;
+ private final PulsarServerCnx cnx;
Review comment:
Ultimately `Consumer` shall depend on the interface and not the
implementation. It's just that I haven't done it yet. Do you want me to do it
in this PR ? It's the next step of my work anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services