merlimat commented on a change in pull request #212: [Issue 211] Fix usage of
MessageChannel in Reader
URL: https://github.com/apache/pulsar-client-go/pull/212#discussion_r407802242
##########
File path: pulsar/consumer.go
##########
@@ -24,7 +24,7 @@ import (
// Pair of a Consumer and Message
type ConsumerMessage struct {
- Consumer
Review comment:
this changes the user API. having a reference to the `Consumer` object is to
give the chance to the user to call `consumer.Ack()` with the message. If we
pass an `interface{}` it would have to downcast
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
