315157973 commented on issue #6764: fix Get schema by version can get the deleted schema info #6754 URL: https://github.com/apache/pulsar/pull/6764#issuecomment-615892696 > We don't need to delete the ledger that stores schemas, the schema delete just add a delete mark in the ledger. There is a method to trim the deleted schemas int the SchemaRegistryServiceImpl. Maybe you can use it directly. > https://github.com/apache/pulsar/blob/9d3ab60efddd3f4064789293fd8e9c4d4388b6c7/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java#L317 Thanks,"trimDeletedSchemaAndGetList" is mainly used to get all the schemas and filter out the deleted ones. It is a query method, not really trimming the schema. If there is no need to delete Ledger, then I will remove this piece of code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
