This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git
commit 4cd61bfca844d76de9c3564521a8c449fa4951e1 Author: Benjamin Huo <hu...@qq.com> AuthorDate: Tue Oct 30 04:00:00 2018 +0800 Fix helm lint error for zookeeper-metadata.yaml (#2878) ### Motivation The following errors occurs when running : helm lint pulsar/ ==> Linting pulsar/ [INFO] Chart.yaml: icon is recommended [ERROR] templates/: render error in "pulsar/templates/zookeeper-metadata.yaml": template: pulsar/templates/zookeeper-metadata.yaml:49:20: executing "pulsar/templates/zookeeper-metadata.yaml" at <.Values.zookeeper_me...>: can't evaluate field resources in type interface {} ### Modifications Change zookeeper_metadata in deployment/kubernetes/helm/pulsar/templates/zookeeper-metadata.yaml to zookeeperMetadata ### Result helm lint pulsar/ ==> Linting pulsar/ [INFO] Chart.yaml: icon is recommended 1 chart(s) linted, no failures --- pulsar/templates/zookeeper-metadata.yaml | 4 ++-- pulsar/values.yaml | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/pulsar/templates/zookeeper-metadata.yaml b/pulsar/templates/zookeeper-metadata.yaml index bb25f46..5115286 100644 --- a/pulsar/templates/zookeeper-metadata.yaml +++ b/pulsar/templates/zookeeper-metadata.yaml @@ -46,9 +46,9 @@ spec: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.zookeeperMetadata.component }}" image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}" imagePullPolicy: {{ .Values.image.pullPolicy }} - {{- if .Values.zookeeper_metadata.resources }} + {{- if .Values.zookeeperMetadata.resources }} resources: -{{ toYaml .Values.zookeeper_metadata.resources | indent 10 }} +{{ toYaml .Values.zookeeperMetadata.resources | indent 10 }} {{- end }} command: ["sh", "-c"] args: diff --git a/pulsar/values.yaml b/pulsar/values.yaml index edbb973..fe237e8 100644 --- a/pulsar/values.yaml +++ b/pulsar/values.yaml @@ -256,6 +256,7 @@ proxy: ## service: annotations: {} + type: NodePort ports: - name: http port: 8080