wolfstudy commented on a change in pull request #6752:
URL: https://github.com/apache/pulsar/pull/6752#discussion_r415055733
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java
##########
@@ -973,8 +982,19 @@ private V1PodSpec getPodSpec(List<String> instanceCommand,
Function.Resources re
V1Container getFunctionContainer(List<String> instanceCommand,
Function.Resources resource) {
final V1Container container = new
V1Container().name(PULSARFUNCTIONS_CONTAINER_NAME);
- // set up the container images
- container.setImage(pulsarDockerImageName);
+ // By default, if we do not use the function image of a specific
language, then we will support all languages.
+ if (javaFunctionDockerImageName == null &&
pythonFunctionDockerImageName == null && goFunctionDockerImageName == null) {
Review comment:
> I think the logic here is completely wrong.
In here, my processing idea uses the original `pulsarDockerImageName` as the
default configuration, that is, when we do not set the corresponding image for
the function of the specified language, we use the default image.
> You should set the correct docker image name based on the language
runtime, not based on whether this configuration is set or not.
Do you mean that we check the image that the user needs to use based on the
parameters passed by the user `--jar`,` --python` or `--go`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
