hangc0276 commented on pull request #6776:
URL: https://github.com/apache/pulsar/pull/6776#issuecomment-619477045


   > > But i am afraid your present implementation will compile failed due to 
lack of `MessageIdImpl` constructor for `@QueryParam("messageId") 
@DefaultValue("latest") MessageIdImpl messageId,`
   > 
   > Yes i was wrong, maybe we should proceed in the following way:
   > 
   > ```
   >             @ApiParam(name = "messageId", value = "messageId where to 
create the subscription. " +
   >                     "It can be 'latest', 'earliest' or (ledgerId:entryId)",
   >                     defaultValue = "latest",
   >                     allowableValues = "latest,earliest,ledgerId:entryId"
   >             ) 
   >             MessageIdImpl messageId,
   > ```
   
   This implementation will not expose messageId to Query param, maybe we'd 
better to use another issue to track it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to