codelipenghui commented on a change in pull request #6862:
URL: https://github.com/apache/pulsar/pull/6862#discussion_r419065174
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -95,7 +95,16 @@ protected ConsumerBase(PulsarClientImpl client, String
topic, ConsumerConfigurat
this.schema = schema;
this.interceptors = interceptors;
if (conf.getBatchReceivePolicy() != null) {
- this.batchReceivePolicy = conf.getBatchReceivePolicy();
+ if (conf.getBatchReceivePolicy().getMaxNumMessages() >
this.maxReceiverQueueSize) {
+ BatchReceivePolicy batchReceivePolicy =
conf.getBatchReceivePolicy();
+ this.batchReceivePolicy = BatchReceivePolicy.builder()
+ .maxNumMessages(this.maxReceiverQueueSize)
+ .maxNumBytes(batchReceivePolicy.getMaxNumBytes())
+ .timeout((int)batchReceivePolicy.getTimeoutMs()/1000,
TimeUnit.SECONDS)
+ .build();
+ } else {
+ this.batchReceivePolicy = conf.getBatchReceivePolicy();
+ }
} else {
this.batchReceivePolicy = BatchReceivePolicy.DEFAULT_POLICY;
Review comment:
We also need to add a check for `DEFAULT_POLICY` since users may specify
the queue size that lower that `maxNumMessages` of the `DEFAULT_POLICY`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
