315157973 removed a comment on pull request #6968: URL: https://github.com/apache/pulsar/pull/6968#issuecomment-631358959
> @315157973 the direction of this change looks great in general. However, I am not sure adding `Type functionGenericType` into the source and sink configs is the best solution. The schema should be inferred from the argument type in the runtime. They shouldn't be tracked in the configs. Can you find a different way to get the type at runtime? When the parameter is passed, only the Class type string of the schema is passed, and the generic type is directly discarded. The only thing we can get later is the Class string, we can't get generics.If we pass the real type instead. However, more parameter types will be modified. JavaInstanceRunnable initializes the schema when calling “setupInput” and “setupOutput” methods. We must determine the schema before producers and consumers create。（Source and Sink） I don’t understand what stage the “runtime” refers to. If we feel that unified processing in topicSchema is not good, how about special treatment for KeyValue after "topicSchema.getSchema" is completed. This way we don't need to change the number of parameters in topicSchema. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
