addisonj commented on pull request #6801: URL: https://github.com/apache/pulsar/pull/6801#issuecomment-632884994
Whoops, I had changed the default in response to feedback and then forgot to update the doc On Fri, May 22, 2020 at 1:42 PM Sanjeev Kulkarni <[email protected]> wrote: > *@srkukarni* commented on this pull request. > ------------------------------ > > In > pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java > <https://github.com/apache/pulsar/pull/6801#discussion_r429425569>: > > > @@ -99,6 +99,17 @@ > doc = "The port for serving worker https requests" > ) > private Integer workerPortTls; > + @FieldContext( > + category = CATEGORY_WORKER, > + doc = "Whether the '/metrics' endpoint requires authentication. Defaults to false." > > does it default to false or true? The doc says one and the default config > says other > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/pulsar/pull/6801#pullrequestreview-417149715>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAE3LA5FKDU2FWRWIAXQT5TRS3IRZANCNFSM4MOXFK7A> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
