merlimat commented on a change in pull request #7111:
URL: https://github.com/apache/pulsar/pull/7111#discussion_r433360867
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
##########
@@ -472,4 +472,9 @@ void asyncSetProperties(Map<String, String> properties,
final AsyncCallbacks.Set
* @param promise
*/
void trimConsumedLedgersInBackground(CompletableFuture<?> promise);
+
+ /**
+ * Roll current ledger if it is full
+ */
+ void rollCurrentLedgerIfFull();
Review comment:
I was thinking that this is a managedLedger internal task, for which the
`BrokerService` shouldn't be concerned. For that it would be better to handle
in the `ManagedLedgerFactoryImpl`, to go through all open managed ledger
instances and check if a rollover has to be forced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
