cbornet commented on a change in pull request #6720:
URL: https://github.com/apache/pulsar/pull/6720#discussion_r435828454
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -506,7 +506,7 @@ protected void handleProducerRemoved(Producer producer) {
}
@Override
- public CompletableFuture<Consumer> subscribe(final ServerCnx cnx, String
subscriptionName, long consumerId,
+ public CompletableFuture<Consumer> subscribe(final TransportCnx cnx,
String subscriptionName, long consumerId,
Review comment:
Not breaking as ServerCnx is now an impl of TransportCnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
