jerrypeng commented on a change in pull request #7187:
URL: https://github.com/apache/pulsar/pull/7187#discussion_r436222531



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1265,7 +1266,8 @@ private void startWorkerService(AuthenticationService 
authenticationService,
                 throw ioe;
             }
             LOG.info("Function worker service setup completed");
-            functionWorkerService.get().start(dlogURI, authenticationService, 
authorizationService);
+            // TODO figure out how to handle errors from function worker 
service
+            functionWorkerService.get().start(dlogURI, authenticationService, 
authorizationService, new ErrorNotifier());

Review comment:
       @merlimat thoughts on how we should hand this if function service is 
running as part of the broker?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to