sijie commented on a change in pull request #6868:
URL: https://github.com/apache/pulsar/pull/6868#discussion_r436843900
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/SchemaDefinitionBuilderImpl.java
##########
@@ -35,7 +35,9 @@
public class SchemaDefinitionBuilderImpl<T> implements
SchemaDefinitionBuilder<T> {
public static final String ALWAYS_ALLOW_NULL = "__alwaysAllowNull";
+ public static final String ALWAYS_ALLOW_NULL_NO_UNDERLINED =
"alwaysAllowNull";
Review comment:
Why can't we use the existing settings?
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/SchemaDefinitionBuilderImpl.java
##########
@@ -35,7 +35,9 @@
public class SchemaDefinitionBuilderImpl<T> implements
SchemaDefinitionBuilder<T> {
public static final String ALWAYS_ALLOW_NULL = "__alwaysAllowNull";
+ public static final String ALWAYS_ALLOW_NULL_NO_UNDERLINED =
"alwaysAllowNull";
Review comment:
Can you explain why do you introduce two new settings without
underscores?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
