jerrypeng commented on a change in pull request #7255:
URL: https://github.com/apache/pulsar/pull/7255#discussion_r440366444
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
##########
@@ -168,68 +151,78 @@ public synchronized boolean containsFunction(String
tenant, String namespace, St
return containsFunctionMetaData(tenant, namespace, functionName);
}
- /**
- * Sends an update request to the FMT (Function Metadata Topic)
- * @param functionMetaData The function metadata that needs to be updated
- * @return a completable future of when the update has been applied
- */
- public synchronized CompletableFuture<RequestResult>
updateFunction(FunctionMetaData functionMetaData) {
-
- FunctionMetaData existingFunctionMetadata = null;
- if (containsFunction(functionMetaData.getFunctionDetails().getTenant(),
- functionMetaData.getFunctionDetails().getNamespace(),
- functionMetaData.getFunctionDetails().getName())) {
- existingFunctionMetadata =
getFunctionMetaData(functionMetaData.getFunctionDetails().getTenant(),
- functionMetaData.getFunctionDetails().getNamespace(),
- functionMetaData.getFunctionDetails().getName());
+ public synchronized void updateFunctionOnLeader(FunctionMetaData
functionMetaData, boolean delete)
+ throws IllegalStateException, IllegalArgumentException {
+ if (exclusiveLeaderProducer == null) {
+ throw new IllegalStateException("Not the leader");
+ }
+ boolean needsScheduling;
+ if (delete) {
+ needsScheduling = proccessDeregister(functionMetaData);
+ } else {
+ needsScheduling = processUpdate(functionMetaData);
+ }
+ Request.ServiceRequest serviceRequest =
Request.ServiceRequest.newBuilder()
+ .setServiceRequestType(delete ?
Request.ServiceRequest.ServiceRequestType.DELETE :
Request.ServiceRequest.ServiceRequestType.UPDATE)
+ .setFunctionMetaData(functionMetaData)
+ .setWorkerId(workerConfig.getWorkerId())
+ .setRequestId(UUID.randomUUID().toString())
+ .build();
+ try {
+ exclusiveLeaderProducer.send(serviceRequest.toByteArray());
Review comment:
Shouldn't we also set a key so that we can use topic compaction?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
