[GitHub] [pulsar] jerrypeng commented on a change in pull request #7255: Re-work Function MetaDataManager to make all metadata writes only by the leader

[GitBox]

jerrypeng commented on a change in pull request #7255:
URL: https://github.com/apache/pulsar/pull/7255#discussion_r442530821



##########
File path: 
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerService.java
##########
@@ -171,6 +171,9 @@ public void start(URI dlogUri,
             this.functionMetaDataManager = new FunctionMetaDataManager(
                     this.workerConfig, this.schedulerManager, this.client, 
errorNotifier);
 
+            // initialize function metadata manager
+            this.functionMetaDataManager.initialize();

Review comment:
       This should happen after membership manager is created/started.  We want 
to do this prior to the worker "joining" the cluster




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org