Huanli-Meng commented on a change in pull request #7297:
URL: https://github.com/apache/pulsar/pull/7297#discussion_r442563073



##########
File path: site2/docs/administration-proxy.md
##########
@@ -34,18 +36,18 @@ brokerWebServiceURL=http://brokers.example.com:8080
 functionWorkerWebServiceURL=http://function-workers.example.com:8080
 ```
 
-Or if you use TLS:
+If you use TLS, configure the broker URLs in the following way:
 ```properties
 brokerServiceURLTLS=pulsar+ssl://brokers.example.com:6651
 brokerWebServiceURLTLS=https://brokers.example.com:8443
 functionWorkerWebServiceURL=https://function-workers.example.com:8443
 ```
 
-The hostname in the URLs provided should be a DNS entry which points to 
multiple brokers or a Virtual IP which is backed by multiple broker IP 
addresses so that the proxy does not lose connectivity to the pulsar cluster if 
a single broker becomes unavailable.
+The hostname in the URLs provided should be a DNS entry which points to 
multiple brokers or a Virtual IP, which is backed by multiple broker IP 
addresses, so that the proxy does not lose connectivity to Pulsar cluster if a 
single broker becomes unavailable.

Review comment:
       ```suggestion
   The hostname in the URLs provided should be a DNS entry which points to 
multiple brokers or a virtual IP address, which is backed by multiple broker IP 
addresses, so that the proxy does not lose connectivity to Pulsar cluster if a 
single broker becomes unavailable.
   ```

##########
File path: site2/docs/administration-proxy.md
##########
@@ -1,30 +1,32 @@
 ---
 id: administration-proxy
-title: The Pulsar proxy
+title: Pulsar proxy
 sidebar_label: Pulsar proxy
 ---
 
-The [Pulsar proxy](concepts-architecture-overview.md#pulsar-proxy) is an 
optional gateway that you can run in front of the brokers in a Pulsar cluster. 
You can run a Pulsar proxy in cases when direction connections between clients 
and Pulsar brokers are either infeasible, undesirable, or both, for example 
when you run Pulsar in a cloud environment or on 
[Kubernetes](https://kubernetes.io) or an analogous platform.
+Pulsar proxy is an optional gateway. Pulsar proxy is used when direction 
connections between clients and Pulsar brokers are either infeasible or 
undesirable. For example, when you run Pulsar in a cloud environment or on 
[Kubernetes](https://kubernetes.io) or an analogous platform, you can run 
Pulsar proxy.
 
 ## Configure the proxy
 
-The proxy must have some way to find the addresses of the brokers of the 
cluster. You can do this by either configuring the proxy to connect directly to 
service discovery or by specifying a broker URL in the configuration. 
+Before using the proxy, you need to configure it with the brokers addresses in 
the cluster. You can configure the proxy to connect directly to service 
discovery, or specify a broker URL in the configuration. 
 
-### Option 1: Use service discovery
+### Use service discovery
 
 Pulsar uses [ZooKeeper](https://zookeeper.apache.org) for service discovery. 
To connect the proxy to ZooKeeper, specify the following in `conf/proxy.conf`.
 ```properties
 zookeeperServers=zk-0,zk-1,zk-2
 configurationStoreServers=zk-0:2184,zk-remote:2184
 ```
 
-> If you use service discovery, the network ACL must allow the proxy to talk 
to the ZooKeeper nodes on the zookeeper client port, which is usually 2181, and 
on the configuration store client port, which is 2184 by default. Opening the 
network ACLs means that if someone compromises a proxy, they have full access 
to ZooKeeper. For this reason, using broker URLs to configure the proxy is more 
secure.
+> To use service discovery, you need to open the network ACLs, so the proxy 
can connects to the ZooKeeper nodes on the ZooKeeper client port(the default is 
`2181`) and the configuration store client port(the default is `2184`).

Review comment:
       ```suggestion
   > To use service discovery, you need to open the network ACLs, so the proxy 
can connects to the ZooKeeper nodes through the ZooKeeper client port (port 
`2181`) and the configuration store client port (port `2184`).
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to