shohi commented on a change in pull request #289:
URL: https://github.com/apache/pulsar-client-go/pull/289#discussion_r442615578
##########
File path: pulsar/consumer_impl.go
##########
@@ -74,6 +74,11 @@ func newConsumer(client *client, options ConsumerOptions)
(Consumer, error) {
options.ReceiverQueueSize = 1000
}
+ // disable receiver queue if queue size is negative
+ if options.ReceiverQueueSize < 0 {
+ options.ReceiverQueueSize = 0
+ }
Review comment:
not sure whether it's a good idea to remove this option. If negative
value is totally disallowed (should be reflected in comments), i think it's ok
to panic though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
