srkukarni commented on a change in pull request #7237:
URL: https://github.com/apache/pulsar/pull/7237#discussion_r442644009
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
##########
@@ -210,21 +210,25 @@ public FunctionRuntimeManager(WorkerConfig workerConfig,
WorkerService workerSer
* 2. After current assignments are read, assignments belonging to this
worker will be processed
*/
public void initialize() {
- log.info("/** Initializing Runtime Manager **/");
try {
- this.functionAssignmentTailer = new FunctionAssignmentTailer(
- this,
- this.getWorkerService().getClient().newReader(),
- this.workerConfig,
- this.errorNotifier);
+
Review comment:
I like that we are no longer using FunctionAssignmenttailer here.
However maybe a static method that consolidates. this reader creation and the
one in assignment tailer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
