[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #292: Used pooled buffering for compression and batch serialization

Sun, 21 Jun 2020 07:02:48 -0700 


merlimat commented on a change in pull request #292:
URL: https://github.com/apache/pulsar-client-go/pull/292#discussion_r443222534



##########
File path: pulsar/consumer_partition.go
##########
@@ -859,7 +859,7 @@ func (pc *partitionConsumer) Decompress(msgMeta 
*pb.MessageMetadata, payload int
                pc.compressionProviders[msgMeta.GetCompression()] = provider
        }
 
-       uncompressed, err := provider.Decompress(payload.ReadableSlice(), 
int(msgMeta.GetUncompressedSize()))
+       uncompressed, err := provider.Decompress(nil, payload.ReadableSlice(), 
int(msgMeta.GetUncompressedSize()))

Review comment:
       It’s an established convention in Go APIs. For example all the 
compression implementations are using that. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to