jerrypeng commented on a change in pull request #7255:
URL: https://github.com/apache/pulsar/pull/7255#discussion_r444435836
##########
File path:
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
##########
@@ -52,20 +61,15 @@
@VisibleForTesting
final Map<String, Map<String, Map<String, FunctionMetaData>>>
functionMetaDataMap = new ConcurrentHashMap<>();
- // A map in which the key is the service request id and value is the
service request
- private final Map<String, ServiceRequestInfo> pendingServiceRequests = new
ConcurrentHashMap<>();
-
private final ServiceRequestManager serviceRequestManager;
private final SchedulerManager schedulerManager;
private final WorkerConfig workerConfig;
private final PulsarClient pulsarClient;
private final ErrorNotifier errorNotifier;
private FunctionMetaDataTopicTailer functionMetaDataTopicTailer;
-
- @Setter
- @Getter
- boolean isInitializePhase = false;
Review comment:
Why are we getting rid of the "isInitializePhase" flag? The flag is in
place so we don't call schedule() for every message during the initialization
phase and we wait to just call schedule at the end of the init phase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
