wolfstudy commented on a change in pull request #309:
URL: https://github.com/apache/pulsar-client-go/pull/309#discussion_r450227808
##########
File path: pulsar/internal/connection.go
##########
@@ -287,8 +287,8 @@ func (c *connection) doHandshake() bool {
c.cnx.SetDeadline(time.Time{})
if cmd.Connected == nil {
- c.log.Warnf("Failed to perform initial handshake - Expecting
'Connected' cmd, got '%s'",
- cmd.Type)
+ c.log.Errorf("Failed to perform initial handshake - Expecting
'Connected' cmd, got '%s'",
Review comment:
About log level I think `Warnf` is more appropriate, it has not reached
the Error level
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
