jerrypeng commented on a change in pull request #7474:
URL: https://github.com/apache/pulsar/pull/7474#discussion_r451308305



##########
File path: 
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/SchedulerManager.java
##########
@@ -368,8 +390,13 @@ private void invokeRebalance() {
             functionRuntimeManager.processAssignment(assignment);
             // update message id associated with current view of assignments 
map
             lastMessageProduced = messageId;
+            // update stats
+            schedulerStats.newAssignment(assignment);
         }
-        log.info("Rebalance - Total number of new assignments computed: {}", 
rebalancedAssignments.size());
+
+        log.info("Rebalance summary - execution time: {} sec | stats: {}\n{}",

Review comment:
       Yes I was going to work on that in the near future.  Stats like 
scheduler execution time can be in prometheus.  However, a breakdown of what 
how many instances moved grouped by worker is not suitable to be put into 
prometheus




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to