seeday commented on pull request #7629: URL: https://github.com/apache/pulsar/pull/7629#issuecomment-662516721
Hi all. This is my first large pulsar PR, and given the contents of it I've got quite a few questions/discussion points about the implementation (in no particular order) - my biggest worry is that the way I've done filtering (acking filtered-out messages on the broker) fails in some strange case - additionally, the performance of running the filter inside the jetty thread-loop might be questionable, but I feel like running it in the consumer send function would be worse (as I think that's single threaded?). - reflection to create the filter classes isn't pretty, but it allows for easy user extension. Is that reason enough to have it? - also, what kind of filters should pulsar itself be in the business of providing? I only created a few to prove out the feature, but they also cover a relatively large amount of my use-case. - Is there a better way to send over arguments to the filter? I used KeyValue since it was convenient, but sending serialized objects of some sort would be much nicer (and necessary for flink integration, as far as I can tell) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
