Huanli-Meng commented on a change in pull request #7627: URL: https://github.com/apache/pulsar/pull/7627#discussion_r458906442
########## File path: site2/docs/security-oauth2.md ########## @@ -74,20 +74,42 @@ You can use the Oauth2 authentication provider with the following Pulsar clients You can use the factory method to configure authentication for Pulsar Java client. ```java +String issuerUrl = "https://dev-kt-aa9ne.us.auth0.com/oauth/token";; +String credentialsUrl = "file:///path/to/KeyFile.json"; +String audience = "https://dev-kt-aa9ne.us.auth0.com/api/v2/";; + PulsarClient client = PulsarClient.builder() .serviceUrl("pulsar://broker.example.com:6650/") .authentication( - AuthenticationFactoryOAuth2.clientCredentials(this.issuerUrl, this.credentialsUrl, this.audience)) + AuthenticationFactoryOAuth2.clientCredentials(issuerUrl, credentialsUrl, audience)) .build(); ``` In addition, you can also use the encoded parameters to configure authentication for Pulsar Java client. ```java Authentication auth = AuthenticationFactory - .create(AuthenticationOAuth2.class.getName(), "{"type":"client_credentials","privateKey":"...","issuerUrl":"...","audience":"..."}"); + .create(AuthenticationOAuth2.class.getName(), "{"type":"client_credentials","privateKey":"./key/path/..","issuerUrl":"...","audience":"..."}"); PulsarClient client = PulsarClient.builder() .serviceUrl("pulsar://broker.example.com:6650/") .authentication(auth) .build(); -``` \ No newline at end of file +``` + +### CPP + +Cpp client is similar to java client. user need to provide parameters of issuerUrl, private_key(which is the credentials file path), and audience. Review comment: ```suggestion The C++ client is similar to the Java client. You need to provide parameters of `issuerUrl`, `private_key` (the credentials file path), and the audience. ``` ########## File path: site2/docs/security-oauth2.md ########## @@ -74,20 +74,42 @@ You can use the Oauth2 authentication provider with the following Pulsar clients You can use the factory method to configure authentication for Pulsar Java client. ```java +String issuerUrl = "https://dev-kt-aa9ne.us.auth0.com/oauth/token";; +String credentialsUrl = "file:///path/to/KeyFile.json"; +String audience = "https://dev-kt-aa9ne.us.auth0.com/api/v2/";; + PulsarClient client = PulsarClient.builder() .serviceUrl("pulsar://broker.example.com:6650/") .authentication( - AuthenticationFactoryOAuth2.clientCredentials(this.issuerUrl, this.credentialsUrl, this.audience)) + AuthenticationFactoryOAuth2.clientCredentials(issuerUrl, credentialsUrl, audience)) .build(); ``` In addition, you can also use the encoded parameters to configure authentication for Pulsar Java client. ```java Authentication auth = AuthenticationFactory - .create(AuthenticationOAuth2.class.getName(), "{"type":"client_credentials","privateKey":"...","issuerUrl":"...","audience":"..."}"); + .create(AuthenticationOAuth2.class.getName(), "{"type":"client_credentials","privateKey":"./key/path/..","issuerUrl":"...","audience":"..."}"); PulsarClient client = PulsarClient.builder() .serviceUrl("pulsar://broker.example.com:6650/") .authentication(auth) .build(); -``` \ No newline at end of file +``` + +### CPP Review comment: ```suggestion ### C++ client ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
