lbenc135 opened a new pull request #7662:
URL: https://github.com/apache/pulsar/pull/7662


   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the 
pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull 
request.
       Skip *component* if you are unsure about which is the best component. 
E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   Partially solves #4234
   
   ### Motivation
   
   The C++ and Python client's logging is not configurable and the stdout is 
spammed with pulsar logs.
   
   The clients provides an option of specifying a `log4cxx.conf` file, but this 
had no effect because it was ignored.
   
   
   ### Modifications
   
   Enabled Log4cxx and fixed the Log4Cxx logger (some leftovers from previous 
refactor).
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   Not sure how to test this with unit tests, but I compiled it locally, tried 
it out, even used it in a project, and it works.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): yes (maybe)
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: don't know
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to