shohi commented on a change in pull request #323:
URL: https://github.com/apache/pulsar-client-go/pull/323#discussion_r462992494



##########
File path: pulsar/client.go
##########
@@ -91,6 +92,9 @@ type ClientOptions struct {
 
        // Max number of connections to a single broker that will kept in the 
pool. (Default: 1 connection)
        MaxConnectionsPerBroker int
+
+       // Configure the logger used by the client. (Default: 
logrus.StandardLogger())
+       Logger *logrus.Logger

Review comment:
       it makes sense, i defined the `Logger` and `Entry` interfaces at 
`pulsar/log` package, please take a look :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to