jianyun8023 commented on a change in pull request #7747:
URL: https://github.com/apache/pulsar/pull/7747#discussion_r466304256
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java
##########
@@ -86,123 +71,172 @@ public void cleanup() throws Exception {
public void testSetBacklogQuota() throws Exception {
BacklogQuota backlogQuota = new BacklogQuota(1024,
BacklogQuota.RetentionPolicy.consumer_backlog_eviction);
- log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
backlogQuotaTopic);
+ log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
testTopic);
- admin.topics().setBacklogQuota(backlogQuotaTopic, backlogQuota);
- log.info("Backlog quota set success on topic: {}", backlogQuotaTopic);
+ admin.topics().setBacklogQuota(testTopic, backlogQuota);
+ log.info("Backlog quota set success on topic: {}", testTopic);
Thread.sleep(3000);
- BacklogQuota getBacklogQuota =
admin.topics().getBacklogQuotaMap(backlogQuotaTopic)
+ BacklogQuota getBacklogQuota =
admin.topics().getBacklogQuotaMap(testTopic)
.get(BacklogQuota.BacklogQuotaType.destination_storage);
- log.info("Backlog quota {} get on topic: {}", getBacklogQuota,
backlogQuotaTopic);
+ log.info("Backlog quota {} get on topic: {}", getBacklogQuota,
testTopic);
Assert.assertEquals(getBacklogQuota, backlogQuota);
BacklogQuotaManager backlogQuotaManager =
pulsar.getBrokerService().getBacklogQuotaManager();
- BacklogQuota backlogQuotaInManager =
backlogQuotaManager.getBacklogQuota(TopicName.get(backlogQuotaTopic));
- log.info("Backlog quota {} in backlog quota manager on topic: {}",
backlogQuotaInManager, backlogQuotaTopic);
+ BacklogQuota backlogQuotaInManager =
backlogQuotaManager.getBacklogQuota(TopicName.get(testTopic));
+ log.info("Backlog quota {} in backlog quota manager on topic: {}",
backlogQuotaInManager, testTopic);
Assert.assertEquals(backlogQuotaInManager, backlogQuota);
- admin.topics().deletePartitionedTopic(backlogQuotaTopic, true);
+ admin.topics().deletePartitionedTopic(testTopic, true);
}
@Test
public void testRemoveBacklogQuota() throws Exception {
BacklogQuota backlogQuota = new BacklogQuota(1024,
BacklogQuota.RetentionPolicy.consumer_backlog_eviction);
- log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
backlogQuotaTopic);
- admin.topics().setBacklogQuota(backlogQuotaTopic, backlogQuota);
- log.info("Backlog quota set success on topic: {}", backlogQuotaTopic);
+ log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
testTopic);
+ admin.topics().setBacklogQuota(testTopic, backlogQuota);
+ log.info("Backlog quota set success on topic: {}", testTopic);
Thread.sleep(3000);
- BacklogQuota getBacklogQuota =
admin.topics().getBacklogQuotaMap(backlogQuotaTopic)
+ BacklogQuota getBacklogQuota =
admin.topics().getBacklogQuotaMap(testTopic)
.get(BacklogQuota.BacklogQuotaType.destination_storage);
- log.info("Backlog quota {} get on topic: {}", getBacklogQuota,
backlogQuotaTopic);
+ log.info("Backlog quota {} get on topic: {}", getBacklogQuota,
testTopic);
Assert.assertEquals(backlogQuota, getBacklogQuota);
BacklogQuotaManager backlogQuotaManager =
pulsar.getBrokerService().getBacklogQuotaManager();
- BacklogQuota backlogQuotaInManager =
backlogQuotaManager.getBacklogQuota(TopicName.get(backlogQuotaTopic));
- log.info("Backlog quota {} in backlog quota manager on topic: {}",
backlogQuotaInManager, backlogQuotaTopic);
+ BacklogQuota backlogQuotaInManager =
backlogQuotaManager.getBacklogQuota(TopicName.get(testTopic));
+ log.info("Backlog quota {} in backlog quota manager on topic: {}",
backlogQuotaInManager, testTopic);
Assert.assertEquals(backlogQuota, backlogQuotaInManager);
- admin.topics().removeBacklogQuota(backlogQuotaTopic);
- getBacklogQuota = admin.topics().getBacklogQuotaMap(backlogQuotaTopic)
+ admin.topics().removeBacklogQuota(testTopic);
+ getBacklogQuota = admin.topics().getBacklogQuotaMap(testTopic)
.get(BacklogQuota.BacklogQuotaType.destination_storage);
- log.info("Backlog quota {} get on topic: {} after remove",
getBacklogQuota, backlogQuotaTopic);
+ log.info("Backlog quota {} get on topic: {} after remove",
getBacklogQuota, testTopic);
Assert.assertNull(getBacklogQuota);
- backlogQuotaInManager =
backlogQuotaManager.getBacklogQuota(TopicName.get(backlogQuotaTopic));
+ backlogQuotaInManager =
backlogQuotaManager.getBacklogQuota(TopicName.get(testTopic));
log.info("Backlog quota {} in backlog quota manager on topic: {} after
remove", backlogQuotaInManager,
- backlogQuotaTopic);
+ testTopic);
Assert.assertEquals(backlogQuotaManager.getDefaultQuota(),
backlogQuotaInManager);
- admin.topics().deletePartitionedTopic(backlogQuotaTopic, true);
+ admin.topics().deletePartitionedTopic(testTopic, true);
}
@Test
- public void testCheckQuota() throws Exception {
+ public void testCheckBlcklogQuota() throws Exception {
RetentionPolicies retentionPolicies = new RetentionPolicies(10, 10);
- String namespace = TopicName.get(backlogQuotaTopic).getNamespace();
+ String namespace = TopicName.get(testTopic).getNamespace();
admin.namespaces().setRetention(namespace, retentionPolicies);
BacklogQuota backlogQuota =
new BacklogQuota(10 * 1024 * 1024,
BacklogQuota.RetentionPolicy.consumer_backlog_eviction);
- log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
backlogQuotaTopic);
+ log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
testTopic);
try {
- admin.topics().setBacklogQuota(backlogQuotaTopic, backlogQuota);
+ admin.topics().setBacklogQuota(testTopic, backlogQuota);
Assert.fail();
} catch (PulsarAdminException e) {
Assert.assertEquals(e.getStatusCode(), 412);
}
Thread.sleep(3000);
backlogQuota =
new BacklogQuota(10 * 1024 * 1024 + 1,
BacklogQuota.RetentionPolicy.consumer_backlog_eviction);
- log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
backlogQuotaTopic);
+ log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
testTopic);
try {
- admin.topics().setBacklogQuota(backlogQuotaTopic, backlogQuota);
+ admin.topics().setBacklogQuota(testTopic, backlogQuota);
Assert.fail();
} catch (PulsarAdminException e) {
Assert.assertEquals(e.getStatusCode(), 412);
}
Thread.sleep(3000);
backlogQuota =
new BacklogQuota(10 * 1024 * 1024 - 1,
BacklogQuota.RetentionPolicy.consumer_backlog_eviction);
- log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
backlogQuotaTopic);
- admin.topics().setBacklogQuota(backlogQuotaTopic, backlogQuota);
+ log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
testTopic);
+ admin.topics().setBacklogQuota(testTopic, backlogQuota);
Thread.sleep(3000);
- BacklogQuota getBacklogQuota =
admin.topics().getBacklogQuotaMap(backlogQuotaTopic)
+ BacklogQuota getBacklogQuota =
admin.topics().getBacklogQuotaMap(testTopic)
.get(BacklogQuota.BacklogQuotaType.destination_storage);
- log.info("Backlog quota {} get on topic: {} after remove",
getBacklogQuota, backlogQuotaTopic);
+ log.info("Backlog quota {} get on topic: {} after remove",
getBacklogQuota, testTopic);
Assert.assertEquals(getBacklogQuota, backlogQuota);
- admin.topics().deletePartitionedTopic(backlogQuotaTopic, true);
+ admin.topics().deletePartitionedTopic(testTopic, true);
}
@Test
- public void testBacklogQuotaDisabled() throws Exception {
- disableTopicLevelPolicies();
- admin.topics().createPartitionedTopic(backlogQuotaTopic, 2);
-
- BacklogQuota backlogQuota = new BacklogQuota(1024,
BacklogQuota.RetentionPolicy.consumer_backlog_eviction);
- log.info("Backlog quota: {} will set to the topic: {}", backlogQuota,
backlogQuotaTopic);
+ public void testCheckRetention() throws Exception {
+ BacklogQuota backlogQuota =
Review comment:
This is a problem, I have modified it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
