Huanli-Meng commented on a change in pull request #7779:
URL: https://github.com/apache/pulsar/pull/7779#discussion_r468380901
##########
File path: site2/docs/admin-api-namespaces.md
##########
@@ -621,7 +621,7 @@ admin.namespaces().getDispatchRate(namespace)
#### set dispatch throttling for subscription
It sets message dispatch rate for all the subscription of topics under a given
namespace.
-Dispatch rate can be restricted by number of message per X seconds
(`msg-dispatch-rate`) or by number of message-bytes per X second
(`byte-dispatch-rate`).
+Dispatch rate can be restricted by the number of messages per X seconds
(`msg-dispatch-rate`) or by the number of message-bytes per X second
(`byte-dispatch-rate`).
Review comment:
```suggestion
The dispatch rate can be restricted by the number of messages per X seconds
(`msg-dispatch-rate`) or by the number of bytes per X second
(`byte-dispatch-rate`).
```
##########
File path: site2/docs/admin-api-namespaces.md
##########
@@ -498,7 +498,7 @@
admin.namespaces().clearNamespaceBundleBacklogForSubscription(namespace, bundle,
#### set retention
-Each namespace contains multiple topics and each topic’s retention size
(storage size) should not exceed to a specific threshold or it should be stored
till certain time duration. This command helps to configure retention size and
time of topics in a given namespace.
+Each namespace contains multiple topics and each topic’s retention size
(storage size) should not exceed a specific threshold or it should be stored
till a certain time duration. This command helps to configure retention size
and time of topics in a given namespace.
Review comment:
```suggestion
Each namespace contains multiple topics and the retention size (storage
size) of each topic should not exceed a specific threshold or it should be
stored for a certain period. This command helps configure the retention size
and time of topics in a given namespace.
```
##########
File path: site2/docs/admin-api-namespaces.md
##########
@@ -336,7 +336,7 @@ admin.namespaces().getPersistence(namespace)
#### unload namespace bundle
-Namespace bundle is a virtual group of topics which belong to same namespace.
If broker gets overloaded with number of bundles then this command can help to
unload heavy bundle from that broker, so it can be served by some other less
loaded broker. Namespace bundle is defined with it’s start and end range such
as 0x00000000 and 0xffffffff.
+Namespace bundle is a virtual group of topics which belong to the same
namespace. If broker gets overloaded with the number of bundles then this
command can help to unload heavy bundle from that broker, so it can be served
by some other less loaded broker. Namespace bundle is defined with it’s start
and end range such as 0x00000000 and 0xffffffff.
Review comment:
```suggestion
The namespace bundle is a virtual group of topics which belong to the same
namespace. If the broker gets overloaded with the number of bundles, this
command can help unload heavy bundle from that broker, so it can be served by
some other less-loaded brokers. The namespace bundle ID ranges from 0x00000000
to 0xffffffff.
```
##########
File path: site2/docs/admin-api-namespaces.md
##########
@@ -555,7 +555,7 @@ admin.namespaces().getRetention(namespace)
#### set dispatch throttling
It sets message dispatch rate for all the topics under a given namespace.
-Dispatch rate can be restricted by number of message per X seconds
(`msg-dispatch-rate`) or by number of message-bytes per X second
(`byte-dispatch-rate`).
+Dispatch rate can be restricted by the number of messages per X seconds
(`msg-dispatch-rate`) or by the number of message-bytes per X second
(`byte-dispatch-rate`).
Review comment:
```suggestion
The dispatch rate can be restricted by the number of messages per X seconds
(`msg-dispatch-rate`) or by the number of bytes per X second
(`byte-dispatch-rate`).
```
##########
File path: site2/docs/admin-api-namespaces.md
##########
@@ -679,7 +679,7 @@ admin.namespaces().getSubscriptionDispatchRate(namespace)
#### set dispatch throttling for replicator
It sets message dispatch rate for all the replicator between replication
clusters under a given namespace.
-Dispatch rate can be restricted by number of message per X seconds
(`msg-dispatch-rate`) or by number of message-bytes per X second
(`byte-dispatch-rate`).
+Dispatch rate can be restricted by the number of messages per X seconds
(`msg-dispatch-rate`) or by the number of message-bytes per X second
(`byte-dispatch-rate`).
Review comment:
```suggestion
The dispatch rate can be restricted by the number of messages per X seconds
(`msg-dispatch-rate`) or by the number of bytes per X second
(`byte-dispatch-rate`).
```
##########
File path: site2/docs/admin-api-namespaces.md
##########
@@ -679,7 +679,7 @@ admin.namespaces().getSubscriptionDispatchRate(namespace)
#### set dispatch throttling for replicator
It sets message dispatch rate for all the replicator between replication
clusters under a given namespace.
-Dispatch rate can be restricted by number of message per X seconds
(`msg-dispatch-rate`) or by number of message-bytes per X second
(`byte-dispatch-rate`).
+Dispatch rate can be restricted by the number of messages per X seconds
(`msg-dispatch-rate`) or by the number of message-bytes per X second
(`byte-dispatch-rate`).
Review comment:
```suggestion
The dispatch rate can be restricted by the number of messages per X seconds
(`msg-dispatch-rate`) or by the number of bytes per X second
(`byte-dispatch-rate`).
```
##########
File path: site2/docs/admin-api-namespaces.md
##########
@@ -178,11 +178,11 @@
admin.namespaces().getNamespaceReplicationClusters(namespace)
#### set backlog quota policies
-Backlog quota helps broker to restrict bandwidth/storage of a namespace once
it reach certain threshold limit . Admin can set this limit and one of the
following action after the limit is reached.
+Backlog quota helps the broker to restrict bandwidth/storage of a namespace
once it reach a certain threshold limit. Admin can set this limit and one of
the following actions after the limit is reached.
1. producer_request_hold: broker will hold and not persist produce request
payload
- 2. producer_exception: broker will disconnects with client by giving
exception
+ 2. producer_exception: broker will disconnect with the client by giving an
exception
Review comment:
```suggestion
2. producer_exception: broker disconnects with the client by giving an
exception.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
