jianyun8023 edited a comment on pull request #7802: URL: https://github.com/apache/pulsar/pull/7802#issuecomment-672918381
Can I not pass `AsyncResponse` to the base class? Make `internalSetMaxUnackedMessagesOnSubscription` return `CompletableFuture<Void>`. Other methods are like this. You can refer to [modify the use of asyncResponse](https://github.com/apache/pulsar/pull/7747/commits/bebd6f7455e8af5d512ca40c476ac400cbf08dac) I think this can the base class and make it cleaner. en, I am going to post an issue description. @codelipenghui What do you think？ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
