BewareMyPower commented on a change in pull request #7823:
URL: https://github.com/apache/pulsar/pull/7823#discussion_r471197144
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
##########
@@ -720,16 +720,36 @@ private void
removeExpiredMessagesFromQueue(Set<MessageId> messageIds) {
}
}
- private boolean topicNameValid(String topicName) {
- return TopicName.isValid(topicName) && !topics.containsKey(topicName);
+ private TopicName getTopicName(String topic) {
+ try {
+ return TopicName.get(topic);
+ } catch (Exception ignored) {
+ return null;
+ }
+ }
+
+ private String getFullTopicName(String topic) {
+ TopicName topicName = getTopicName(topic);
+ return (topicName != null) ? topicName.toString() : null;
+ }
+
+ private void removeTopic(String topic) {
+ String fullTopicName = getFullTopicName(topic);
+ if (fullTopicName != null) {
+ topics.remove(topic);
+ }
}
// subscribe one more given topic
public CompletableFuture<Void> subscribeAsync(String topicName, boolean
createTopicIfDoesNotExist) {
- if (!topicNameValid(topicName)) {
+ TopicName topicNameInstance = getTopicName(topicName);
Review comment:
I validate it in line 746 to 748. Because `TopicName` could be reused,
if I wrap the validation in `topicNameValid`, I have to create `TopicName` to
get full topic name and partitioned topic name again. I can't think an elegant
way to do it so I create a `TopicName` instance at first of `subscribeAsync`
and do checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
