MarvinCai opened a new pull request #7831:
URL: https://github.com/apache/pulsar/pull/7831
Fixes #7397
### Motivation
When use pulsar-admin to create a subscription on a non-persistent topic,
get the server error
This change return more informative error message when trying to create
subscript ion on non-persistent through Rest API or pulsar-admin CLI.
### Modifications
Currently when creating subscription is called with non-persistent topic
service will try to create the subscription which will fail with casting
exception when trying to cast NonPersistentSubscription to
PersistentSubscription and client will see internal error.
Add check if create subscription command is called for a non-persistent
topic before actually
### Verifying this change
This change added tests and can be verified as follows:
- Added unit test
- Verified with local standalone
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
