jerrypeng commented on a change in pull request #7898:
URL: https://github.com/apache/pulsar/pull/7898#discussion_r477575214
##########
File path:
tests/integration/src/test/java/org/apache/pulsar/tests/integration/containers/PulsarContainer.java
##########
@@ -146,6 +146,26 @@ public void start() {
beforeStart();
super.start();
+ if (this.getContainerName().contains("presto-worker")) {
Review comment:
I don't think this is the best way to get the logs of containers as they
will be sprinkled across the whole test log. We should just upload relevant
log artifacts. All the containers already dump its logs in compressed format
(please reference:
https://github.com/apache/pulsar/blob/master/tests/integration/src/test/java/org/apache/pulsar/tests/integration/utils/DockerUtils.java#L117)
. We just need to upload the logs as artifacts at when the test is done
running so that users can download all the logs to view/debug. This is what
was done when we were on Jenkins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
