codelipenghui commented on a change in pull request #7833:
URL: https://github.com/apache/pulsar/pull/7833#discussion_r478232637
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
##########
@@ -2857,5 +2857,14 @@ private int applyMaxSizeCap(int maxEntries, long
maxSizeBytes) {
return Math.min(maxEntriesBasedOnSize, maxEntries);
}
+
+ public void internalInitBatchDeletedIndex(PositionImpl position, int
totalNumMessageInBatch) {
+ if (!batchDeletedIndexes.containsKey(position)) {
+ BitSetRecyclable bitSetRecyclable = BitSetRecyclable.create();
+ bitSetRecyclable.set(0, totalNumMessageInBatch);
+ batchDeletedIndexes.put(position, bitSetRecyclable);
+ }
Review comment:
batchDeletedIndexes.computeIfAbsent().
##########
File path: .github/workflows/ci-unit-broker-broker-gp1.yaml
##########
@@ -65,13 +65,13 @@ jobs:
if: steps.docs.outputs.changed_only == 'no'
run: ./build/retry.sh mvn -B -ntp test -pl pulsar-broker
-Dinclude='**/AdminApiOffloadTest.java' -DtestForkCount=1 -DtestReuseFork=true
- - name: run flaky test '**/TransactionProduceTest.java'
+ - name: run transaction test
if: steps.docs.outputs.changed_only == 'no'
- run: ./build/retry.sh mvn -B -ntp test -pl pulsar-broker
-Dinclude='**/TransactionProduceTest.java' -DtestForkCount=1
-DtestReuseFork=true
+ run: ./build/retry.sh mvn -B -ntp test -pl pulsar-broker
-Dinclude='org/apache/pulsar/broker/transaction/**/*.java,org/apache/pulsar/client/transaction/**/*.java'
-DfailIfNoTests=false -DtestForkCount=1 -DtestReuseFork=true
- name: run unit tests for pulsar-broker
if: steps.docs.outputs.changed_only == 'no'
- run: ./build/retry.sh mvn -B -ntp test -pl pulsar-broker
-Dinclude='org/apache/pulsar/broker/**/*.java'
-Dexclude='org/apache/pulsar/broker/zookeeper/**/*.java,org/apache/pulsar/broker/loadbalance/**/*.java,org/apache/pulsar/broker/service/**/*.java,**/AdminApiOffloadTest.java,**/TransactionProduceTest.java'
+ run: ./build/retry.sh mvn -B -ntp test -pl pulsar-broker
-Dinclude='org/apache/pulsar/broker/**/*.java'
-Dexclude='org/apache/pulsar/broker/zookeeper/**/*.java,org/apache/pulsar/broker/loadbalance/**/*.java,org/apache/pulsar/broker/service/**/*.java,**/AdminApiOffloadTest.java,org/apache/pulsar/broker/transaction/**/*.java,org/apache/pulsar/client/transaction/**/*.java'
Review comment:
Shall we need this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
