smazurov commented on a change in pull request #7503:
URL: https://github.com/apache/pulsar/pull/7503#discussion_r479488909
##########
File path: pulsar-client-cpp/lib/ClientImpl.cc
##########
@@ -97,20 +97,18 @@ ClientImpl::ClientImpl(const std::string& serviceUrl, const
ClientConfiguration&
requestIdGenerator_(0),
closingError(ResultOk) {
std::unique_ptr<LoggerFactory> loggerFactory =
clientConfiguration_.impl_->takeLogger();
- if (!logger) {
Review comment:
This breaks all custom logging implementations. `loggerFactory` is now
set to either `SimpleLoggerFactory` or `Log4CxxLoggerFactory` even if client
configuration sets one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
