BewareMyPower commented on pull request #7932: URL: https://github.com/apache/pulsar/pull/7932#issuecomment-683538925
LGTM. Since the bug was introduced because there's no way to verify for custom logger currently, I thought it could be better to add an unit test for custom logger, e.g. use a custom logger to write logs to a file with a specific prefix, then read the file to check if every line has the prefix. I have written a [simple test](https://gist.github.com/BewareMyPower/c304fb33a77f408f1247143958088030) and run the tests with gtest-parallel, it works well. However, without gtest-parallel, logs of other unit tests could be written to the same file because the logger of each file was `thread_local`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
