codelipenghui edited a comment on pull request #7937: URL: https://github.com/apache/pulsar/pull/7937#issuecomment-686985367
@lhotari Thanks for the comment. This will not cause issues in consistency, this PR only add check for the acknowledge method. Currently, the acknowledgment is in a `try best` way. > for example have some kind of state machine / model that would help organize the code in a better way? Sounds good. If you are interested in this part, feel free to push forward. > Another unrelated observation is that there are a lot of synchronized methods in the PersistentSubscription class, however I guess there isn't a lockfree design in Pulsar in general. Yes, maybe this is the part that can be improved. Some seem to be unnecessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
