Dishwasha opened a new pull request #7516:
URL: https://github.com/apache/pulsar/pull/7516
### Motivation
Databases like PostgreSQL support table partitioning which will
cause the table not to be found in getTableId for jdbc sink/sources.
### Modifications
Adding "PARTITIONED TABLE" to the types passed to getTables fixes this.
### Verifying this change
Unfortunately the test suite doesn't pass for me even before this change,
but I ran the following after re-building the connector and no longer get
the table not found message.
```bin/pulsar-admin sinks create --tenant mytenant--namespace mynamespace
--name mysink --archive ./connectors/pulsar-io-jdbc-postgres-2.6.0.nar --inputs
mytopic --sink-config-file ./connectors/postgres.yaml --processingGuarantees
EFFECTIVELY_ONCE --parallelism 1```
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not applicable
- If a feature is not applicable for documentation, explain why?
Supporting partitioned tables shouldn't have to be specifically mentioned in
documentation
- If a feature is not documented yet in this PR, please create a followup
issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
