jiazhai commented on a change in pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006#discussion_r485540308



##########
File path: pulsar-client-cpp/lib/auth/AuthOauth2.cc
##########
@@ -300,7 +364,7 @@ AuthenticationPtr AuthOauth2::create(const std::string& 
authParamsString) {
 
 AuthenticationPtr AuthOauth2::create(ParamMap& params) { return 
AuthenticationPtr(new AuthOauth2(params)); }
 
-const std::string AuthOauth2::getAuthMethodName() const { return "token"; }
+const std::string AuthOauth2::getAuthMethodName() const { return "oauth2"; }

Review comment:
       @zymap Could we keep it as token? client get token finally from oauth2 
server, and broker side could use token to talk with client




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to