sijie commented on a change in pull request #8132:
URL: https://github.com/apache/pulsar/pull/8132#discussion_r498001964
##########
File path: pulsar-function-go/pf/instanceConf.go
##########
@@ -72,8 +73,8 @@ func newInstanceConf() *instanceConf {
SubscriptionType:
pb.SubscriptionType(cfg.SubscriptionType),
InputSpecs: map[string]*pb.ConsumerSpec{
cfg.SourceSpecTopic: {
- SchemaType:
cfg.SourceSchemaType,
- IsRegexPattern:
cfg.IsRegexPatternSubscription,
+ SchemaType: "",
+ IsRegexPattern: false,
Review comment:
Why do you change this to `false`?
##########
File path: pulsar-function-go/pf/instanceConf.go
##########
@@ -72,8 +73,8 @@ func newInstanceConf() *instanceConf {
SubscriptionType:
pb.SubscriptionType(cfg.SubscriptionType),
InputSpecs: map[string]*pb.ConsumerSpec{
cfg.SourceSpecTopic: {
- SchemaType:
cfg.SourceSchemaType,
- IsRegexPattern:
cfg.IsRegexPatternSubscription,
+ SchemaType: "",
Review comment:
Why do you change the `SchemaType` to an empty string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
