languitar opened a new pull request #8213: URL: https://github.com/apache/pulsar/pull/8213
Fixes #7050 ### Motivation To prevent installing enum34 on systems where it is not needed, declare the dependency with environment markers. Installing certain versions of enum34 on systems where it is not needed at all, might result in compile time issues. This is the recommended approach discussed here: https://github.com/python-poetry/poetry/issues/1122 ### Modifications * `setup.py`: use environment markers for enum34 instead of custom logic that is not preserved in pypi metadata for the wheel ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as all python tests ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): no - The public API: no - The schema: no - The default values of configurations: no - The wire protocol: no - The rest endpoints: no - The admin cli options: no - *Anything that affects deployment*: don't know ### Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable - If a feature is not applicable for documentation, explain why? Only packaging change ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
