codelipenghui commented on a change in pull request #8208:
URL: https://github.com/apache/pulsar/pull/8208#discussion_r501029758
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##########
@@ -145,6 +147,8 @@ public PulsarClientImpl(ClientConfigurationData conf,
EventLoopGroup eventLoopGr
conf.getAuthentication().start();
this.cnxPool = cnxPool;
externalExecutorProvider = new
ExecutorProvider(conf.getNumListenerThreads(),
getThreadFactory("pulsar-external-listener"));
+ ioExecutorService = new ThreadPoolExecutor(conf.getNumIoThreads(),
conf.getNumIoThreads(), 0L, TimeUnit.MILLISECONDS,
+ new LinkedBlockingQueue<>(),
getThreadFactory("pulsar-io-thread"));
Review comment:
Now we already have threads named `pulsar-client-io`, so it's better to
use a different name for the new threads. And I noticed some internal tasks of
the client also uses the `externalExecutorProvider` for executing the internal
task of the Pulsar client. Maybe we can add an `internalExecutorService` for
handing the internal tasks of the client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
