murong00 commented on pull request #8269: URL: https://github.com/apache/pulsar/pull/8269#issuecomment-709671928
> LGTM. Just one point, I think it's better to change > > > --existing-bk-metadata-service-uri "zk+null://bk1:2181;bk2:2181/ledgers" > > to `zk1:2181,zk2:2181` to emphasize that the metadata store is ZK (not Etcd,etc.) or just `host1:2181,host2:2181` to be consistent with other params. @BewareMyPower I agree with you, however the result of command `bin/bookkeeper shell whatisinstanceid` is semicolon separated in multi-hosts case (due to bookkeeper only support semicolon separated values currently, you can refer to #6998 for some detail), if we replace semicolon with comma the `BkClient` will fail to be created, so I just keep its result here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
